merged code for rstudio addin, updated DESCRIPTION imports and docs. #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrjoh3 I haven't forgotten and sorry for the delay. I still plan to get this in the next release. Thanks so much for the pull!! |
|
That's fine @timelyportfolio there is no rush. Something to consider though, is that CRAN might not like the way the addin works as it is able to write to .GlobalEnv and to the file system. When you come to look at the PR please let me know if you need anything changed. |
Open
|
superseded by #122 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addin merge seems to work as expected. I have run
devtools::check()without error. One possible issue is that the addin assigns to the .GlobalEnv which flags as a note in the checks. I will investigate a more elegant alternative.